openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
92 stars 182 forks source link

Upgrade from CentOS 8 compatibility #1637

Closed elfosardo closed 4 months ago

elfosardo commented 4 months ago

Restart network service after removing the old network definitions to completely remove them and allow upgrade in CentOS 8 old dev-scripts deployments.

elfosardo commented 4 months ago

/retest

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [zaneb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
elfosardo commented 4 months ago

/retest a possible fix for the MCO issue has been merged

elfosardo commented 4 months ago

/retest MCO should be fixed now

openshift-ci[bot] commented 4 months ago

@elfosardo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack ab39b119607b1dc12afaa28c754814f7570f86fc link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-virtualmedia ab39b119607b1dc12afaa28c754814f7570f86fc link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-bm-bond ab39b119607b1dc12afaa28c754814f7570f86fc link false /test e2e-metal-ipi-bm-bond
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 ab39b119607b1dc12afaa28c754814f7570f86fc link false /test e2e-metal-ipi-serial-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
derekhiggins commented 4 months ago

/retest-require /lgtm

derekhiggins commented 4 months ago

/retest-required

dtantsur commented 4 months ago

For anyone wondering, the error message you get without this is:

You still get it with this PR :(