openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
92 stars 182 forks source link

01_requirements.sh errors when `go` is pre-installed. #1639

Closed psathyan closed 4 months ago

psathyan commented 4 months ago

Describe the bug When we attempt to rerun make after a clean, 01_install_requirements.sh always fails with the below error message

        "\u001b[0;31m    \"msg\": \"Request failed\",\u001b[0m",                                                                                                                                                   
        "\u001b[0;31m    \"response\": \"HTTP Error 404: Not Found\",\u001b[0m",                                                                                                                                   
        "\u001b[0;31m    \"status_code\": 404,\u001b[0m",                                                                                                                                                          
        "\u001b[0;31m    \"url\": \"https://storage.googleapis.com/golang/gogo1.19.10.linux-amd64.tar.gz\"\u001b[0m",                                                                                              
        "\u001b[0;31m}\u001b[0m",    

To Reproduce

  1. Clone the repository
  2. Ensure all the pre-requisites are meet
  3. Change to dev-scripts directory
  4. Execute make
  5. After performing your testing
  6. Execute make clean
  7. Redeploy the environment using make

Expected/observed behavior Redeployment must be successful Observing failure as described in the description

Additional context

1634 introduced GOVERSION and the expected value conflicts with the actual value. That is, when performing eval "$(go env)", then GOVERSION=go1.20 is set however GOVERSION expects only the version number and not the prefix go