search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
92 stars 182 forks source link

Change the go version variable name. #1640

Closed psathyan closed 4 months ago

psathyan commented 4 months ago

In this PR, we change the variable GOVERSION to GO_VERSION to prevent encountering failures due to mismatched value format.

If go is exists and we execute make, then GOVERSION=go<version> is format of the value being set. However, install-package-playbook.yml expects the value to be only the version instead of the prefix go.

Fixes #1639

openshift-ci[bot] commented 4 months ago

Hi @psathyan. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
elfosardo commented 4 months ago

/ok-to-test

elfosardo commented 4 months ago

/lgtm

CrystalChun commented 4 months ago

/retest-required

zaneb commented 4 months ago

/approve

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [zaneb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 4 months ago

@psathyan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-bm-bond 7c7c81921b0e61b00eb4a0ac7c420b17c747458f link false /test e2e-metal-ipi-bm-bond
ci/prow/e2e-metal-ipi-virtualmedia 7c7c81921b0e61b00eb4a0ac7c420b17c747458f link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 7c7c81921b0e61b00eb4a0ac7c420b17c747458f link false /test e2e-metal-ipi-serial-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
psathyan commented 4 months ago

/retest-required