search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
92 stars 182 forks source link

Fix upgrade from CS8 compatibility #1642

Closed elfosardo closed 4 months ago

elfosardo commented 4 months ago

systemctl requires sudo to run also removing the || true to avoid covering hidden errors, the network service should always be present before the migration and if any ifcfg file is there

dtantsur commented 4 months ago

/approve

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
elfosardo commented 4 months ago

/retest

elfosardo commented 4 months ago

/retest we can probably override the jobs though as this patch does not touch the normal workflow

elfosardo commented 4 months ago

/override ci/prow/e2e-metal-ipi-ovn-dualstack

openshift-ci[bot] commented 4 months ago

@elfosardo: Overrode contexts on behalf of elfosardo: ci/prow/e2e-metal-ipi-ovn-dualstack

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1642#issuecomment-1991608703): >/override ci/prow/e2e-metal-ipi-ovn-dualstack Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
elfosardo commented 4 months ago

/override ci/prow/e2e-metal-ipi-serial-ovn-ipv6

openshift-ci[bot] commented 4 months ago

@elfosardo: Overrode contexts on behalf of elfosardo: ci/prow/e2e-metal-ipi-serial-ovn-ipv6

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1642#issuecomment-1991814538): >/override ci/prow/e2e-metal-ipi-serial-ovn-ipv6 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
honza commented 4 months ago

nit: more detail in the commit message would be nice

/lgtm

elfosardo commented 4 months ago

nit: more detail in the commit message would be nice

/lgtm

@honza thanks, you're right, I've updated the description