search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
93 stars 185 forks source link

Bump go_version to 1.22.1 #1645

Closed msherif1234 closed 3 months ago

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign bfournie for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
msherif1234 commented 6 months ago

/retest

elfosardo commented 6 months ago

not sure we're ready to bump to GO 1.22 considering that all containers are currently based on GO 1.21 probably better to keep that version for consistency

openshift-ci[bot] commented 6 months ago

@msherif1234: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-bm b26c8533ec2f0781336abcc960190e016bcdc315 link true /test e2e-metal-ipi-bm
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 b26c8533ec2f0781336abcc960190e016bcdc315 link false /test e2e-metal-ipi-serial-ovn-ipv6
ci/prow/e2e-metal-ipi-serial-ipv4 b26c8533ec2f0781336abcc960190e016bcdc315 link true /test e2e-metal-ipi-serial-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
msherif1234 commented 6 months ago

not sure we're ready to bump to GO 1.22 considering that all containers are currently based on GO 1.21 probably better to keep that version for consistency

there are new packages now that won't be updated because it has strict dependency on go 1.22

elfosardo commented 6 months ago

@msherif1234 can you please provide some examples?

msherif1234 commented 6 months ago

@msherif1234 can you please provide some examples?

https://github.com/openshift/ingress-node-firewall/pull/501 https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_ingress-node-firewall/501/pull-ci-openshift-ingress-node-firewall-master-unit-test/1772308335786201088

here is another recent example https://github.com/openshift/ingress-node-firewall/pull/515

so it seems shortly we will be stucked

msherif1234 commented 4 months ago

@elfosardo is good time now to switch to go1.22 since we have art image for 1.22 now and its blocking many dependencies PRs

msherif1234 commented 3 months ago

not needed anymore it seems go version has already been updated