search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
92 stars 182 forks source link

OCPBUGS-20097: Extract oc RHEL8 binary from release explicitly #1646

Closed ardaguclu closed 3 months ago

ardaguclu commented 4 months ago

In the course of bumping oc's base image to RHEL9, it is needed that the environments bases on RHEL 8 (at least for now) to use oc RHEL8 binary. This PR enables that when the dev-scripts is also bumped to RHEL9, it will be an easy change to use oc.rhel9 explicitly.

This PR changes the extraction of oc to oc.rhel8 which exists in 4.15 and 4.16 release payloads and fall backs to default oc for older releases.

openshift-ci[bot] commented 3 months ago

@soltysh: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1646#pullrequestreview-1966615225): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ardaguclu commented 3 months ago

/retest

ardaguclu commented 3 months ago

/retest

ardaguclu commented 3 months ago

/retest

ardaguclu commented 3 months ago

@bfournie @dtantsur @derekhiggins could you PTAL?. Thanks.

elfosardo commented 3 months ago

/retest

elfosardo commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

@ardaguclu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-sno-ipv6 acc6013efcab9f00bd462217d9f5b7f9c4ce07dd link false /test e2e-agent-sno-ipv6
ci/prow/e2e-metal-ipi-virtualmedia acc6013efcab9f00bd462217d9f5b7f9c4ce07dd link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 acc6013efcab9f00bd462217d9f5b7f9c4ce07dd link false /test e2e-metal-ipi-serial-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
soltysh commented 3 months ago

@elfosardo mind also approving the PR?

derekhiggins commented 3 months ago

ci tested this on a rhel8 host, tested on a rhel9 host locally (with both 4.15 and 4.13 payloads) /approve

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [derekhiggins] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment