search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
92 stars 182 forks source link

Always mirror with --keep-manifest-list=true #1648

Open derekhiggins opened 3 months ago

derekhiggins commented 3 months ago

The code to conditionaly add --keep-manifest-list=true to the mirror command was added for a now unsupported version of OC. Remove it as it doesn't always work e.g. if the .releaseClientVersion doesn't follow the 4.XX... format.

4.15.0-0.nightly-2024-..-..... vs 0.0.1-0.test-2024-....-latest

elfosardo commented 3 months ago

/lgtm

dtantsur commented 2 months ago

/approve

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
derekhiggins commented 2 months ago

ci/prow/e2e-metal-ipi-serial-ipv4

derekhiggins commented 2 months ago

/test e2e-metal-ipi-serial-ipv4

derekhiggins commented 2 months ago

/test e2e-metal-ipi-serial-ipv4

openshift-ci[bot] commented 2 months ago

@derekhiggins: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-ha-dualstack 7203534389fa7f2f2824faf26b28e1285e8c1426 link false /test e2e-agent-ha-dualstack
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 7203534389fa7f2f2824faf26b28e1285e8c1426 link false /test e2e-metal-ipi-serial-ovn-ipv6
ci/prow/e2e-agent-compact-ipv4 7203534389fa7f2f2824faf26b28e1285e8c1426 link unknown /test e2e-agent-compact-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).