search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
92 stars 182 forks source link

CORS-3462: use static openshift-installer when possible #1651

Closed r4f4 closed 3 months ago

r4f4 commented 3 months ago

With https://github.com/openshift/installer/pull/8161, the baremetal installer is now part of the regular installer which is now statically linked.

Using the static binary has the advantage of working on both CS8 and CS9 VMs and is a necessary step for moving the Installer images to a RHEL9 base.

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign cybertron for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 months ago

Hi @r4f4. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
andfasano commented 3 months ago

/ok-to-test

r4f4 commented 3 months ago

/retitle CORS-3024,CORS-2797: use static openshift-installer when possible

openshift-ci[bot] commented 3 months ago

@r4f4: Re-titling can only be requested by trusted users, like repository collaborators.

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1651#issuecomment-2058670253): >/retitle CORS-3024,CORS-2797: use static openshift-installer when possible Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
zaneb commented 3 months ago

/retitle CORS-3462: use static openshift-installer when possible

dtantsur commented 3 months ago

I wonder if this actually works. The CI fails with

rhcos.sh: line 26: ocp/cluster16/openshift-baremetal-install: No such file or directory

This file uses variable called OPENSHIFT_INSTALLER. I'm not sure why @zaneb suggested _CMD suffix, but we now need to update a lot more places.

andfasano commented 3 months ago

/retest-required

@r4f4 in general the changes look fine to me, leaving the final approval to the metal folks since it will impact mostly metal jobs

openshift-ci[bot] commented 3 months ago

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack 454c29ceb8684fe44c1077d3aa3f7b90b76d99d7 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-ovn-ipv6 454c29ceb8684fe44c1077d3aa3f7b90b76d99d7 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-metal-ipi-virtualmedia 454c29ceb8684fe44c1077d3aa3f7b90b76d99d7 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-bm-bond 454c29ceb8684fe44c1077d3aa3f7b90b76d99d7 link false /test e2e-metal-ipi-bm-bond
ci/prow/e2e-agent-ha-dualstack 454c29ceb8684fe44c1077d3aa3f7b90b76d99d7 link false /test e2e-agent-ha-dualstack
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 454c29ceb8684fe44c1077d3aa3f7b90b76d99d7 link false /test e2e-metal-ipi-serial-ovn-ipv6
ci/prow/e2e-agent-compact-ipv4 454c29ceb8684fe44c1077d3aa3f7b90b76d99d7 link true /test e2e-agent-compact-ipv4
ci/prow/e2e-metal-ipi-bm 454c29ceb8684fe44c1077d3aa3f7b90b76d99d7 link true /test e2e-metal-ipi-bm
ci/prow/e2e-metal-ipi-serial-ipv4 454c29ceb8684fe44c1077d3aa3f7b90b76d99d7 link true /test e2e-metal-ipi-serial-ipv4
ci/prow/e2e-agent-sno-ipv6 454c29ceb8684fe44c1077d3aa3f7b90b76d99d7 link false /test e2e-agent-sno-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
r4f4 commented 3 months ago

/hold Depends on https://github.com/openshift-metal3/dev-scripts/pull/1652

zaneb commented 3 months ago

/close in favour of #1653

openshift-ci[bot] commented 3 months ago

@zaneb: Closed this PR.

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1651#issuecomment-2071004159): >/close >in favour of #1653 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.