search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
92 stars 182 forks source link

Assign OPENSHIFT_VERSION early if not manually defined #1652

Closed elfosardo closed 2 months ago

elfosardo commented 3 months ago

/retest

dtantsur commented 3 months ago

/approve

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
elfosardo commented 3 months ago

/retest

elfosardo commented 3 months ago

/retest

openshift-ci[bot] commented 3 months ago

@elfosardo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-ha-dualstack b885ada462137dd722b51ba87f523547dc2e9b5f link false /test e2e-agent-ha-dualstack
ci/prow/e2e-metal-ipi-bm-bond b885ada462137dd722b51ba87f523547dc2e9b5f link false /test e2e-metal-ipi-bm-bond
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 b885ada462137dd722b51ba87f523547dc2e9b5f link false /test e2e-metal-ipi-serial-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
elfosardo commented 3 months ago

/hold I'm not happy either about this, I was looking for a way to just get OPENSHIFT_VERSION early during the run to be available for the entire process, but at some point we got in a dependency loop. Besides the fact that bash is definitely not the right way to go, we should find an alternative to provide all the needed info, especially a basic one like the running openshift version, at the start of the script. I won't continue this, but I'll leave it here for the time being just as a reminder of the current status of dev-scripts.