search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
92 stars 182 forks source link

CORS-3462: extract static openshift-installer from 4.16 #1653

Closed zaneb closed 3 months ago

zaneb commented 3 months ago

With https://github.com/openshift/installer/pull/8161, the baremetal installer is now part of the regular installer which is now statically linked.

Using the static binary has the advantage of working on both CS8 and CS9 VMs and is a necessary step for moving the Installer images to a RHEL9 base.

zaneb commented 3 months ago

This is a potential alternative to #1651

zaneb commented 3 months ago

/cc @r4f4, @elfosardo

r4f4 commented 3 months ago

LGTM

zaneb commented 3 months ago

/retest-required

elfosardo commented 3 months ago

/lgtm

elfosardo commented 3 months ago

/retest

dtantsur commented 3 months ago

/approve

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
honza commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

@zaneb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-bm-bond 2ac6e79ca22d23adea7446114ba026cb0596ef11 link false /test e2e-metal-ipi-bm-bond
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 2ac6e79ca22d23adea7446114ba026cb0596ef11 link false /test e2e-metal-ipi-serial-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
r4f4 commented 3 months ago

/test e2e-metal-ipi-serial-ipv4