search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
93 stars 185 forks source link

AGENT-864: New make target to add day2 node with agent #1654

Closed rwsu closed 2 months ago

rwsu commented 5 months ago

The new target is named "agent_add_node".

Requires at least one extra worker node to be defined.

export NUM_EXTRA_WORKERS=1

Extra worker disk must be at least 100GB to pass assisted service validations.

export EXTRA_WORKER_DISK=100

If multiple extraworker nodes were provisioned, you can specify which node to add to the cluster through a new AGENT_EXTRAWORKER_NODE_TO_ADD environment variable.

For example, if your cluster was created with NUM_EXTRA_WORKERS=2, you can add both nodes to the cluster using these commands: AGENT_EXTRAWORKER_NODE_TO_ADD=0 make agent_add_node AGENT_EXTRAWORKER_NODE_TO_ADD=1 make agent_add_node

The target calls "node-joiner add-nodes" to create the addnodes ISO. It then attaches the ISO to extraworker-0 and boots it. It finally calls "node-joiner monitor-add-nodes" to monitor progress. In the background, dev-scripts approves any CSRs so that the node joins the cluster and becomes Ready.

Depends on: https://github.com/openshift/installer/pull/8171

rwsu commented 5 months ago

/cc @andfasano @bfournie @pawanpinjarkar /uncc @lranjbar @cybertron

rwsu commented 5 months ago

/hold

Cannot add --auto-approve-csrs flag to monitor-add-nodes command. Need to approve CSRs within dev-scripts.

rwsu commented 5 months ago

/unhold

rwsu commented 3 months ago

/retest-required

andfasano commented 3 months ago

/test e2e-agent-sno-ipv6

andfasano commented 2 months ago

/approve

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [andfasano] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
andfasano commented 2 months ago

/retest-required

rwsu commented 2 months ago

/test e2e-metal-ipi-bm

andfasano commented 2 months ago

/override ci/prow/e2e-metal-ipi-bm

The current patch does not relate to the metal-ipi-bm failure, which seems due a degraded operator

openshift-ci[bot] commented 2 months ago

@andfasano: Overrode contexts on behalf of andfasano: ci/prow/e2e-metal-ipi-bm

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1654#issuecomment-2245647794): >/override ci/prow/e2e-metal-ipi-bm > >The current patch does not relate to the metal-ipi-bm failure, which seems due a degraded operator Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rwsu commented 2 months ago

/test e2e-metal-ipi-serial-ipv4

rwsu commented 2 months ago

/override ci/prow/e2e-metal-ipi-serial-ipv4 failures are not related to the patch.

openshift-ci[bot] commented 2 months ago

@rwsu: rwsu unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1654#issuecomment-2246862250): >/override ci/prow/e2e-metal-ipi-serial-ipv4 >failures are not related to the patch. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
andfasano commented 2 months ago

/test e2e-metal-ipi-serial-ipv4

andfasano commented 2 months ago

/override ci/prow/e2e-metal-ipi-serial-ipv4

There are some e2e tests failures that do not look related to the current patch

openshift-ci[bot] commented 2 months ago

@andfasano: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1654#issuecomment-2252532807): >/override ci/prow/e2e-metal-ipi-serial-ipv4 > >There are some e2e tests failures that do not look related to the current patch Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
andfasano commented 2 months ago

/override ci/prow/e2e-metal-ipi-serial-ipv4

openshift-ci[bot] commented 2 months ago

@andfasano: Overrode contexts on behalf of andfasano: ci/prow/e2e-metal-ipi-serial-ipv4

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1654#issuecomment-2252674589): >/override ci/prow/e2e-metal-ipi-serial-ipv4 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.