search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
92 stars 182 forks source link

OCPBUGS-34581: Fix bad dns agent test for ocp 4.16 #1661

Closed andfasano closed 1 month ago

andfasano commented 1 month ago

This patch fixes the failing AGENT_TEST_CASES bad_dns script. Since Openshift 4.16, the nmtui main panel shows an additional "Radio" entry, thus requiring an additional step for a proper selection.

andfasano commented 1 month ago

cc @rwsu

dtantsur commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[agent/OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/agent/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment