search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
93 stars 185 forks source link

Upgrade golang to 1.22.3 #1662

Closed honza closed 3 months ago

elfosardo commented 4 months ago

/lgtm

andfasano commented 4 months ago

/approve

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [andfasano] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
andfasano commented 4 months ago

/retest-required

dtantsur commented 3 months ago

/retest-required

dtantsur commented 3 months ago

/override ci/prow/e2e-metal-ipi-bm

The Go version does not affect the actually provisioned cluster. I don't want to hold an import Go update forever on unstable jobs.

openshift-ci[bot] commented 3 months ago

@dtantsur: Overrode contexts on behalf of dtantsur: ci/prow/e2e-metal-ipi-bm

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1662#issuecomment-2165264710): >/override ci/prow/e2e-metal-ipi-bm > >The Go version does not affect the actually provisioned cluster. I don't want to hold an import Go update forever on unstable jobs. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.