search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
93 stars 185 forks source link

Another attempt to update Ansible and metal3-dev-env #1666

Closed dtantsur closed 3 months ago

dtantsur commented 3 months ago

The previous one got reverted because it did not account for certain variable changes.

elfosardo commented 3 months ago

do we want to add the migration to ansible 7 here or open a new PR? Looking at the logs this passed with the offending change, so it looks good

derekhiggins commented 3 months ago

/lgtm

honza commented 3 months ago

Do we want a newer version of metal3-dev-env? It currently points to a version from April 2023.

dtantsur commented 3 months ago

Do we want a newer version of metal3-dev-env? It currently points to a version from April 2023.

One step at a time, okay? :) We already have an idea what breaks with this version, the next one will probably need more investigation.

derekhiggins commented 3 months ago

/test e2e-metal-ipi-serial-ipv4

elfosardo commented 3 months ago

/retest failure does not look related

elfosardo commented 3 months ago

/retest timeout in ipv4

derekhiggins commented 3 months ago

/approve

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [derekhiggins] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
elfosardo commented 3 months ago

/hold let's wait for the weekend :)

elfosardo commented 3 months ago

/retest

elfosardo commented 3 months ago

/unhold