search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
92 stars 182 forks source link

AGENT-925: Block port 22624 when adding day 2 worker node #1671

Open rwsu opened 4 weeks ago

rwsu commented 4 weeks ago

22624 is the insecure port for the machine config server. Day 2 nodes should be communicating through the secure port 22623. By blocking the insecure port for extra worker nodes, we force them to use the secure port.

The filter isn't applied to master or worker nodes because they fetch their ignition through the secure port during initial installation.

openshift-ci[bot] commented 4 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from rwsu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[agent/OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/agent/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment