Error during "make clean"

spk-hebbar commented 2 days ago

Describe the bug During make clean, I see the following error.

 ./agent/cleanup.sh: line 24: BOOT_SERVER_DIR: unbound variable
    ++(./agent/cleanup.sh:1): removetmp
    ++(/home/zuul/src/github.com/openshift-metal3/dev-scripts/utils.sh:875): removetmp(): '[' -n '' ']'
    ++(/home/zuul/src/github.com/openshift-metal3/dev-scripts/utils.sh:875): removetmp(): true
  stdout_lines: <omitted>

To Reproduce I'm running this via ci-framework and here is the commit I am on:

$ git log
commit b33cc7867e132ae30cae58b47574447606c380e1 (grafted, HEAD -> master, origin/master, origin/HEAD)
Author: Bob Fournie <bfournie@redhat.com>
Date:   Tue Nov 12 18:03:58 2024 -0500

    AGENT-975: Add support for agent-based installer minimal ISO (#1711)

    Configure the installer to create a minimal ISO. Add support
    for a nimimal ISO installation in a disconnected environment
    using the bootArtifactsBaseURL field. Made the PXE server into
    a more generic boot server that can be used to server the rootfs
    for minimal ISO.

Expected/observed behavior make clean to go through smoothly.

bfournie commented 2 days ago

Fix is here https://github.com/openshift-metal3/dev-scripts/pull/1718

bfournie commented 1 day ago

Fixed. /close

openshift-ci[bot] commented 1 day ago

@bfournie: Closing this issue.

In response to [this](https://github.com/openshift-metal3/dev-scripts/issues/1717#issuecomment-2477497059): >Fixed. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

openshift-metal3 / dev-scripts

Error during "make clean" #1717