openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
93 stars 185 forks source link

infinite loop #346

Closed jtaleric closed 5 years ago

jtaleric commented 5 years ago

If there is a networking hiccup with the setup, this loop could cause the scripts to wait forever[1].

+ host -t SRV _etcd-server-ssl._tcp.ostest.test.metalkube.org api.ostest.test.metalkube.org
+ echo -n .
.+ sleep 1
+ host -t SRV _etcd-server-ssl._tcp.ostest.test.metalkube.org api.ostest.test.metalkube.org
+ echo -n .
.+ sleep 1
+ host -t SRV _etcd-server-ssl._tcp.ostest.test.metalkube.org api.ostest.test.metalkube.org
+ echo -n .
.+ sleep 1

[1] https://github.com/openshift-metalkube/dev-scripts/blob/master/utils.sh#L162

celebdor commented 5 years ago

Without this baremetal just doesn't work anyway :-)

celebdor commented 5 years ago

But IIRC in baremetal for now people run it separately from the make workflow.

celebdor commented 5 years ago

@derekhiggins @karmab ^^

jtaleric commented 5 years ago

ah? it is part of the make workflow (since it is in the 06 script)

celebdor commented 5 years ago

yeah, I meant additionally.

celebdor commented 5 years ago

https://github.com/openshift-metalkube/dev-scripts/issues/333

jtaleric commented 5 years ago

ah ha, #333 shouldn't be impacted here, as I am using libvirt DNS. Let'ts see if the ns1 addition gets me a success!

russellb commented 5 years ago

@jtaleric feel free to reopen this issue if needed. As @celebdor notes, if DNS isn't working, the cluster isn't going to come up anyway.