search

openshift-metal3 / terraform-provider-ironic

Terraform provider for Ironic
Apache License 2.0
24 stars 25 forks source link

CI: use combined Ironic, drop MariaDB #65

Closed hs0210 closed 2 years ago

hs0210 commented 2 years ago

Replace 3 containers(mariadb, ironic-api, ironic-conductor) with the combined one(ironic) to improve CI.

Signed-off-by: Hu Shuai hus.fnst@fujitsu.com

openshift-ci[bot] commented 2 years ago

Hi @hs0210. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
elfosardo commented 2 years ago

/cc @dtantsur @iurygregory

openshift-ci[bot] commented 2 years ago

@elfosardo: GitHub didn't allow me to request PR reviews from the following users: iurygregory.

Note that only openshift-metal3 members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift-metal3/terraform-provider-ironic/pull/65#issuecomment-1088375045): >/cc @dtantsur @iurygregory Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
elfosardo commented 2 years ago

/lgtm

elfosardo commented 2 years ago

/ok-to-test

dtantsur commented 2 years ago

/approve

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/terraform-provider-ironic/blob/master/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment