search

openshift-online / maestro

Maestro Service Repo
Apache License 2.0
8 stars 15 forks source link

Make the NewRESTFullAPIWatcherStore client resilient and reliable on full resync #131

Open machi1990 opened 2 weeks ago

machi1990 commented 2 weeks ago

This is to track https://github.com/openshift-online/maestro/issues/104#issuecomment-2167777162 The client I was using is similar to https://github.com/openshift-online/maestro/blob/main/examples/manifestworkclient/client-a/main.go

and I toggled WithResyncEnabled(true) to true /cc @skeeey

skeeey commented 1 week ago

The resync is only for the client that has the local cache, in our case, the client does not have the local cache, so we should not enable the resync

I enhanced the RESTFulAPIWatcherStore in #133, it will list works from maestro server when a watcher is required, so that we have a full sync when a client is created