search

openshift-online / ocm-api-model

Apache License 2.0
4 stars 95 forks source link

Modify notify_details response #884

Closed Lir10 closed 10 months ago

Lir10 commented 11 months ago

@etabak @zgalor ptal

tzvatot commented 11 months ago

@Lir10 should this be reflected in https://api.openshift.com/?urls.primaryName=Accounts%20management%20service#/default/post_api_accounts_mgmt_v1_notify_details? I don't see these fields currently

Lir10 commented 10 months ago

@tzvatot yes, we are working on merging it in AMS

Lir10 commented 10 months ago

@tzvatot it was merged can you please merge this MR ?

tzvatot commented 10 months ago

@tzvatot it was merged can you please merge this MR ?

@Lir10 the API seems to not be consistent with the general API, where subscription is a struct, and under that you have the fields of "id", "kind" and "href".

Lir10 commented 10 months ago

@tzvatot sure, this is not a standard API .. it's used specifically for OSL to get some data. there's no need for the other fields

Lir10 commented 10 months ago

created a ticket https://issues.redhat.com/browse/OCM-5561