search

openshift-pipelines / console-plugin

OpenShift Pipelines (and Tekton) OpenShift console dynamic plugin
Apache License 2.0
2 stars 15 forks source link

[release-v1.15.x] OCPBUGS-33571: Remove duplicates code and cleanup #109

Closed openshift-cherrypick-robot closed 6 months ago

openshift-cherrypick-robot commented 6 months ago

This is an automated cherry-pick of #105

/assign vikram-raj

openshift-ci-robot commented 6 months ago

@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-33569 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh: /jira refresh

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/109): >This is an automated cherry-pick of #105 > >/assign vikram-raj Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-pipelines%2Fconsole-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 6 months ago

@openshift-ci-robot: This pull request references Jira Issue OCPBUGS-33569, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/109#issuecomment-2106757168): >@openshift-cherrypick-robot: Could not make automatic cherrypick of [Jira Issue OCPBUGS-33569](https://issues.redhat.com//browse/OCPBUGS-33569) for this PR as the target version is not set for this branch in the jira plugin config. Running refresh: >/jira refresh > >
> >In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/109): > >>This is an automated cherry-pick of #105 >> >>/assign vikram-raj > > >Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-pipelines%2Fconsole-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository. >

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci[bot] commented 6 months ago

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a openshift-pipelines member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
vikram-raj commented 6 months ago

/ok-to-test

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-pipelines/console-plugin/blob/release-v1.15.x/OWNERS)~~ [vikram-raj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 6 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-33571, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/109): >This is an automated cherry-pick of #105 > >/assign vikram-raj Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-pipelines%2Fconsole-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vikram-raj commented 6 months ago

/jira refresh

openshift-ci-robot commented 6 months ago

@vikram-raj: This pull request references Jira Issue OCPBUGS-33571, which is valid. The bug has been moved to the POST state.

5 validation(s) were run on this bug * bug is open, matching expected state (open) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-33569](https://issues.redhat.com//browse/OCPBUGS-33569) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * bug has dependents

Requesting review from QA contact: /cc @sanketpathak

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/109#issuecomment-2106798924): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-pipelines%2Fconsole-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 6 months ago

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: sanketpathak.

Note that only openshift-pipelines members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/109#issuecomment-2106799072): >@vikram-raj: This pull request references [Jira Issue OCPBUGS-33571](https://issues.redhat.com//browse/OCPBUGS-33571), which is valid. The bug has been moved to the POST state. > >
5 validation(s) were run on this bug > >* bug is open, matching expected state (open) >* bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) >* release note type set to "Release Note Not Required" >* dependent bug [Jira Issue OCPBUGS-33569](https://issues.redhat.com//browse/OCPBUGS-33569) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) >* bug has dependents

Requesting review from QA contact: /cc @sanketpathak

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/109#issuecomment-2106798924): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-pipelines%2Fconsole-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot commented 6 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-33571: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33571 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/109): >This is an automated cherry-pick of #105 > >/assign vikram-raj Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-pipelines%2Fconsole-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.