search

openshift-pipelines / console-plugin

OpenShift Pipelines (and Tekton) OpenShift console dynamic plugin
Apache License 2.0
2 stars 15 forks source link

ODC-7600: Add Timeout field in the start pipeline modal #123

Closed vikram-raj closed 5 months ago

vikram-raj commented 5 months ago

Add a Timeout field in the start pipeline modal

https://github.com/openshift/console/assets/2561818/336610c9-ec87-44d6-8c18-c31a8e12ab94

openshift-ci-robot commented 5 months ago

@vikram-raj: This pull request references ODC-7600 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/123): >Add a Timeout field in the start pipeline modal > >https://github.com/openshift/console/assets/2561818/336610c9-ec87-44d6-8c18-c31a8e12ab94 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-pipelines%2Fconsole-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vikram-raj commented 5 months ago

/retest

lokanandaprabhu commented 5 months ago

Due to new form group, the space is more above Timeouts section, can we add this as part of Parameter section or remove the additional space?

Screenshot 2024-06-12 at 12 32 00 PM
vikram-raj commented 5 months ago

Due to new form group, the space is more above Timeouts section, can we add this as part of Parameter section or remove the additional space?

I added it in a different section as it is not a part of the parameters. Timeout is a different section.

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-pipelines/console-plugin/blob/main/OWNERS)~~ [lokanandaprabhu,vikram-raj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lokanandaprabhu commented 5 months ago

/lgtm