openshift-pipelines / console-plugin

OpenShift Pipelines (and Tekton) OpenShift console dynamic plugin
Apache License 2.0
2 stars 16 forks source link

ODC-7592: Adding pipelines e2e tests from console to console plugin #133

Closed sanketpathak closed 4 months ago

sanketpathak commented 4 months ago

Issue: https://issues.redhat.com/browse/ODC-7592 Story:ODC-7592

Description: Adding e2e test files in the dynamic plugin from the static plugin

Run a test file successfully

Command to execute:

export NO_HEADLESS=true && export CHROME_VERSION=$(/usr/bin/google-chrome-stable --version) BRIDGE_KUBEADMIN_PASSWORD=YH3jN-PRFT2-Q429c-5KQDr BRIDGE_BASE_ADDRESS=https://console-openshift-console.apps.dev-svc-4.13-042801.devcluster.openshift.com/ export BRIDGE_KUBEADMIN_PASSWORD export BRIDGE_BASE_ADDRESS oc login -u kubeadmin -p $BRIDGE_KUBEADMIN_PASSWORD oc apply -f ./tests/utils/htpasswd-secret.yaml oc patch oauths cluster --patch "$(cat ./tests/utils/patch-htpasswd.yaml)" --type=merge ./test-prow-e2e.sh Run create-from-add-options.feature Browser Chrome 125

Screenshot 2024-07-22 at 6 13 55 PM
openshift-ci[bot] commented 4 months ago

Hi @sanketpathak. Thanks for your PR.

I'm waiting for a openshift-pipelines member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
sanketpathak commented 4 months ago

/assign @vikram-raj

vikram-raj commented 4 months ago

/ok-to-test

sanketpathak commented 4 months ago

/cc @ppitonak

openshift-ci[bot] commented 4 months ago

@sanketpathak: GitHub didn't allow me to request PR reviews from the following users: ppitonak.

Note that only openshift-pipelines members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/133#issuecomment-2222447652): >/cc @ppitonak Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
sanketpathak commented 4 months ago

/retest

vikram-raj commented 4 months ago

This PR will update the node version to 18 and fix the node18 issue https://github.com/openshift/release/pull/54408

vikram-raj commented 4 months ago

I tested it, and create-from-add-options.feature is passing for me.

openshift-ci[bot] commented 4 months ago

@ppitonak: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/133#pullrequestreview-2191547001): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
vikram-raj commented 4 months ago

/retest

sanketpathak commented 4 months ago

@ppitonak Can you test again I'm not getting any webpack compilation issue

vikram-raj commented 4 months ago

/retitle ODC-7592: Adding pipelines e2e tests from console to console plugin

openshift-ci-robot commented 4 months ago

@sanketpathak: This pull request references ODC-7592 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/133): >Issue: https://issues.redhat.com/browse/ODC-7592 >Story:[ODC-7592](https://issues.redhat.com/browse/ODC-7592) > >Description: >Adding e2e test files in the dynamic plugin from the static plugin > >Run a test file successfully > >Command to execute: > >export NO_HEADLESS=true && export CHROME_VERSION=$(/usr/bin/google-chrome-stable --version) >BRIDGE_KUBEADMIN_PASSWORD=YH3jN-PRFT2-Q429c-5KQDr >BRIDGE_BASE_ADDRESS=https://console-openshift-console.apps.dev-svc-4.13-042801.devcluster.openshift.com/ >export BRIDGE_KUBEADMIN_PASSWORD >export BRIDGE_BASE_ADDRESS >oc login -u kubeadmin -p $BRIDGE_KUBEADMIN_PASSWORD >oc apply -f ./tests/utils/htpasswd-secret.yaml >oc patch oauths cluster --patch "$(cat ./tests/utils/patch-htpasswd.yaml)" --type=merge >./test-prow-e2e.sh >Run create-from-add-options.feature >Browser >Chrome 125 >Screenshot 2024-07-22 at 6 13 55 PM > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-pipelines%2Fconsole-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanketpathak, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-pipelines/console-plugin/blob/main/OWNERS)~~ [vikram-raj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment