openshift-pipelines / console-plugin

OpenShift Pipelines (and Tekton) OpenShift console dynamic plugin
Apache License 2.0
2 stars 16 forks source link

ODC-7598: Added e2e tests for data source filter group #141

Closed lokanandaprabhu closed 3 months ago

lokanandaprabhu commented 3 months ago

Story: https://issues.redhat.com/browse/ODC-7598

Tests:

Screenshot 2024-07-26 at 12 31 17 PM
openshift-ci-robot commented 3 months ago

@lokanandaprabhu: This pull request references ODC-7598 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/141): >**Story:** >https://issues.redhat.com/browse/ODC-7598 > >**Tests:** >Screenshot 2024-07-26 at 12 31 17 PM > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-pipelines%2Fconsole-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-pipelines/console-plugin/blob/main/OWNERS)~~ [lokanandaprabhu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lokanandaprabhu commented 3 months ago

/cc @vikram-raj @sanketpathak

openshift-ci[bot] commented 3 months ago

@lokanandaprabhu: GitHub didn't allow me to request PR reviews from the following users: sanketpathak.

Note that only openshift-pipelines members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/141#issuecomment-2252387884): >/cc @vikram-raj @sanketpathak Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
invincibleJai commented 3 months ago

/cc @sanketpathak

openshift-ci[bot] commented 3 months ago

@invincibleJai: GitHub didn't allow me to request PR reviews from the following users: sanketpathak.

Note that only openshift-pipelines members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/141#issuecomment-2257599528): >/cc @sanketpathak Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
sanketpathak commented 3 months ago

Tests run green:

Screenshot 2024-07-30 at 5 31 59 PM

/lgtm

openshift-ci[bot] commented 3 months ago

@sanketpathak: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/141#issuecomment-2258226054): >Tests run green: >Screenshot 2024-07-30 at 5 31 59 PM >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
lokanandaprabhu commented 3 months ago

/cc @sanketpathak

lokanandaprabhu commented 3 months ago

/assign @sanketpathak