Closed sanketpathak closed 3 months ago
Hi @sanketpathak. Thanks for your PR.
I'm waiting for a openshift-pipelines member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
@sanketpathak: This pull request references ODC-7601 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
@sanketpathak: This pull request references ODC-7601 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
/ok-to-test
@sanketpathak frontend test is failing due to lint errors. can you PTAL?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lokanandaprabhu, sanketpathak
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Added tests run green.
/lgtm
Story:ODC-7601
Description: Adding e2e test for the new timeout option
Command to execute:
export NO_HEADLESS=true && export CHROME_VERSION=$(/usr/bin/google-chrome-stable --version) BRIDGE_KUBEADMIN_PASSWORD=YH3jN-PRFT2-Q429c-5KQDr BRIDGE_BASE_ADDRESS=https://console-openshift-console.apps.dev-svc-4.13-042801.devcluster.openshift.com/ export BRIDGE_KUBEADMIN_PASSWORD export BRIDGE_BASE_ADDRESS oc login -u kubeadmin -p $BRIDGE_KUBEADMIN_PASSWORD oc apply -f ./tests/utils/htpasswd-secret.yaml oc patch oauths cluster --patch "$(cat ./tests/utils/patch-htpasswd.yaml)" --type=merge ./test-prow-e2e.sh -h false Run pipelines-runs.feature Check for second test case Browser: Chrome 125
Screenshot: