openshift-pipelines / console-plugin

OpenShift Pipelines (and Tekton) OpenShift console dynamic plugin
Apache License 2.0
2 stars 16 forks source link

ODC-7601: Add e2e test for the new timeout option #148

Closed sanketpathak closed 3 months ago

sanketpathak commented 3 months ago

Story:ODC-7601

Description: Adding e2e test for the new timeout option

Command to execute:

export NO_HEADLESS=true && export CHROME_VERSION=$(/usr/bin/google-chrome-stable --version) BRIDGE_KUBEADMIN_PASSWORD=YH3jN-PRFT2-Q429c-5KQDr BRIDGE_BASE_ADDRESS=https://console-openshift-console.apps.dev-svc-4.13-042801.devcluster.openshift.com/ export BRIDGE_KUBEADMIN_PASSWORD export BRIDGE_BASE_ADDRESS oc login -u kubeadmin -p $BRIDGE_KUBEADMIN_PASSWORD oc apply -f ./tests/utils/htpasswd-secret.yaml oc patch oauths cluster --patch "$(cat ./tests/utils/patch-htpasswd.yaml)" --type=merge ./test-prow-e2e.sh -h false Run pipelines-runs.feature Check for second test case Browser: Chrome 125

Screenshot:

Screenshot 2024-08-06 at 11 46 43 AM
openshift-ci[bot] commented 3 months ago

Hi @sanketpathak. Thanks for your PR.

I'm waiting for a openshift-pipelines member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 3 months ago

@sanketpathak: This pull request references ODC-7601 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/148): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-pipelines%2Fconsole-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 months ago

@sanketpathak: This pull request references ODC-7601 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/148): >Story:[ODC-7601](https://issues.redhat.com/browse/ODC-7601) > >Description: >Adding e2e test for the new timeout option > >Command to execute: > >export NO_HEADLESS=true && export CHROME_VERSION=$(/usr/bin/google-chrome-stable --version) >BRIDGE_KUBEADMIN_PASSWORD=YH3jN-PRFT2-Q429c-5KQDr >BRIDGE_BASE_ADDRESS=https://console-openshift-console.apps.dev-svc-4.13-042801.devcluster.openshift.com/ >export BRIDGE_KUBEADMIN_PASSWORD >export BRIDGE_BASE_ADDRESS >oc login -u kubeadmin -p $BRIDGE_KUBEADMIN_PASSWORD >oc apply -f ./tests/utils/htpasswd-secret.yaml >oc patch oauths cluster --patch "$(cat ./tests/utils/patch-htpasswd.yaml)" --type=merge >./test-prow-e2e.sh -h false >Run pipelines-runs.feature >Check for second test case >Browser: >Chrome 125 > >Screenshot: >Screenshot 2024-08-06 at 11 46 43 AM > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-pipelines%2Fconsole-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vikram-raj commented 3 months ago

/ok-to-test

vikram-raj commented 3 months ago

@sanketpathak frontend test is failing due to lint errors. can you PTAL?

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-pipelines/console-plugin/blob/main/OWNERS)~~ [lokanandaprabhu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lokanandaprabhu commented 3 months ago
Screenshot 2024-08-08 at 12 12 20 PM

Added tests run green.

/lgtm