search

openshift-pipelines / console-plugin

OpenShift Pipelines (and Tekton) OpenShift console dynamic plugin
Apache License 2.0
2 stars 16 forks source link

SRVKP-5936: Close modal button is not working in dynamic plugin list pages #149

Closed lokanandaprabhu closed 3 months ago

lokanandaprabhu commented 3 months ago

Issue: https://issues.redhat.com/browse/SRVKP-5936

Analysis / Root cause: onClose function was not submitted to Modal component.

Solution Description: Added onClose function to Modal component.

Screen shots / Gifs for design review: ----BEFORE---

https://github.com/user-attachments/assets/211ff1b6-d73a-47b9-b649-f5b9beb19e26

---AFTER---

https://github.com/user-attachments/assets/401d9b34-3637-4b7e-864b-1308dd1074b2

Unit test coverage report: NA

Test setup:

  1. Install Pipelines operator and enable dynamic plugin
  2. Create a pipeline and click on start in kebab menu
  3. Click on X button to close the start pipeline modal

Browser conformance:

openshift-ci-robot commented 3 months ago

@lokanandaprabhu: This pull request references SRVKP-5936 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "Pipelines 1.17.0" instead.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/149): >**Issue:** >https://issues.redhat.com/browse/SRVKP-5936 > >**Analysis / Root cause**: >onClose function was not submitted to Modal component. > >**Solution Description**: >Added onClose function to Modal component. > > >**Screen shots / Gifs for design review**: >----BEFORE--- > > >https://github.com/user-attachments/assets/211ff1b6-d73a-47b9-b649-f5b9beb19e26 > >---AFTER--- > > >https://github.com/user-attachments/assets/401d9b34-3637-4b7e-864b-1308dd1074b2 > > >**Unit test coverage report**: >NA > >**Test setup:** > >1. Install Pipelines operator and enable dynamic plugin >2. Create a pipeline and click on start in kebab menu >3. Click on X button to close the start pipeline modal > > > >**Browser conformance**: > >- [x] Chrome >- [ ] Firefox >- [ ] Safari >- [ ] Edge Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-pipelines%2Fconsole-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-pipelines/console-plugin/blob/main/OWNERS)~~ [lokanandaprabhu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 months ago

@lokanandaprabhu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.13-e2e-tests-aws 42397a27eebf1d0f9942c416d878f419ac6c0a03 link false /test 4.13-e2e-tests-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
vikram-raj commented 3 months ago

/retest

lokanandaprabhu commented 3 months ago

/cherry-pick release-v1.15.x

openshift-cherrypick-robot commented 3 months ago

@lokanandaprabhu: new pull request created: #150

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/149#issuecomment-2274948188): >/cherry-pick release-v1.15.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.