openshift-pipelines / console-plugin

OpenShift Pipelines (and Tekton) OpenShift console dynamic plugin
Apache License 2.0
2 stars 15 forks source link

ODC-7666: Used LogViewer of PF for pipeline logs #153

Closed lokanandaprabhu closed 2 months ago

lokanandaprabhu commented 2 months ago

Story: https://issues.redhat.com/browse/ODC-7666

Description: LogViewer component of PatternFly is used for Pipeline logs

Demo: https://drive.google.com/file/d/1dPHC8a7gMS7azkB0ExSKtSeh_609nZFZ/view?usp=drive_link https://drive.google.com/file/d/1Hf6UrFVLqh45ZfqV4hbZ11yOt12NHSGk/view?usp=drive_link

openshift-ci-robot commented 2 months ago

@lokanandaprabhu: This pull request references ODC-7666 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/153): >**Story:** >https://issues.redhat.com/browse/ODC-7666 > >**Description:** >LogViewer component of PatternFly is used for Pipeline logs Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-pipelines%2Fconsole-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-pipelines/console-plugin/blob/main/OWNERS)~~ [lokanandaprabhu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

@lokanandaprabhu: This pull request references ODC-7666 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/153): >**Story:** >https://issues.redhat.com/browse/ODC-7666 > >**Description:** >LogViewer component of PatternFly is used for Pipeline logs > >**Demo:** >https://drive.google.com/file/d/1dPHC8a7gMS7azkB0ExSKtSeh_609nZFZ/view?usp=drive_link Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-pipelines%2Fconsole-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
lokanandaprabhu commented 2 months ago

Created issues in https://github.com/patternfly/react-log-viewer/issues

https://github.com/patternfly/react-log-viewer/issues/78 - While scrolling in LogViewer, if the log content consists of ANSI color code, then after, on scroll up or scroll down, different colors will show up on the connect

https://github.com/patternfly/react-log-viewer/issues/77 - LogViewer is not maintaining indentation/removing spacing which is prefix to the log data

openshift-ci-robot commented 2 months ago

@lokanandaprabhu: This pull request references ODC-7666 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/153): >**Story:** >https://issues.redhat.com/browse/ODC-7666 > >**Description:** >LogViewer component of PatternFly is used for Pipeline logs > >**Demo:** >https://drive.google.com/file/d/1dPHC8a7gMS7azkB0ExSKtSeh_609nZFZ/view?usp=drive_link >https://drive.google.com/file/d/1Hf6UrFVLqh45ZfqV4hbZ11yOt12NHSGk/view?usp=drive_link Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-pipelines%2Fconsole-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.