search

openshift-pipelines / console-plugin

OpenShift Pipelines (and Tekton) OpenShift console dynamic plugin
Apache License 2.0
2 stars 16 forks source link

SRVKP-6637: Remove All options from project dropdown on overview page for user have no access to all projects #160

Closed lokanandaprabhu closed 4 weeks ago

lokanandaprabhu commented 1 month ago

Fixes: https://issues.redhat.com/browse/SRVKP-6637

----Admin user---

https://drive.google.com/file/d/1FKw1trTy3Gu9Tv0EhRr6_1S_ONhtbQK-/view?usp=drive_link

----Non-admin user who don't have access to All namespace---

https://drive.google.com/file/d/1uh-uwrxNtGNvg0Pd4z-in2vQJJf-LInh/view?usp=drive_link

openshift-ci-robot commented 1 month ago

@lokanandaprabhu: This pull request references SRVKP-6637 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/160): >**Fixes:** >https://issues.redhat.com/browse/SRVKP-6637 > >----Admin user--- > >https://drive.google.com/file/d/1FKw1trTy3Gu9Tv0EhRr6_1S_ONhtbQK-/view?usp=drive_link > >----Non-admin user who don't have access to All namespace--- > >https://drive.google.com/file/d/1uh-uwrxNtGNvg0Pd4z-in2vQJJf-LInh/view?usp=drive_link Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-pipelines%2Fconsole-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-pipelines/console-plugin/blob/main/OWNERS)~~ [lokanandaprabhu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lokanandaprabhu commented 4 weeks ago

Updated the PR and added Project selection page for non-admin user if the namespace is all.

vikram-raj commented 4 weeks ago

/cherry-pick release-v1.16.x

openshift-cherrypick-robot commented 4 weeks ago

@vikram-raj: once the present PR merges, I will cherry-pick it on top of release-v1.16.x in a new PR and assign it to you.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/160#issuecomment-2434833498): >/cherry-pick release-v1.16.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 4 weeks ago

@vikram-raj: new pull request created: #167

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/160#issuecomment-2434833498): >/cherry-pick release-v1.16.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.