search

openshift-pipelines / console-plugin

OpenShift Pipelines (and Tekton) OpenShift console dynamic plugin
Apache License 2.0
2 stars 16 forks source link

SRVKP-6638: PipelineRuns List page doesn't fetch next page data on scroll #161

Closed lokanandaprabhu closed 4 weeks ago

lokanandaprabhu commented 1 month ago

Fixes: https://issues.redhat.com/browse/SRVKP-6638

Description: VirtualizedTable which is exposed to dynamic plugin is missing onRowsRendered prop which is available in VirtualTableBody of PatternFly.

Created https://issues.redhat.com/browse/OCPBUGS-43538 ticket for that.

Once this ticket is closed, instead of the solution provided in this PR we have to use onRowsRendered prop in VirtualizedTable to call nextPageToken.

Demo: ----PipelineRun list page---

https://drive.google.com/file/d/1HO6V5AnMSRqVgTTf1hAIT-COVCH2Q701/view?usp=drive_link

----TaskRun list page---

https://drive.google.com/file/d/1FlOn6Zp3aEKxFlAmivy1IiFRWUUYrPyk/view?usp=drive_link

openshift-ci-robot commented 1 month ago

@lokanandaprabhu: This pull request references SRVKP-6638 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/161): >**Fixes:** >https://issues.redhat.com/browse/SRVKP-6638 > >**Description:** > `VirtualizedTable` which is exposed to dynamic plugin is missing `onRowsRendered` prop which is available in `VirtualTableBody` of PatternFly. > >Created https://issues.redhat.com/browse/OCPBUGS-43538 ticket for that. > >Once this ticket is closed, instead of the solution provided in this PR we have to use `onRowsRendered` prop in `VirtualizedTable` to call `nextPageToken`. > >**Demo:** >----PipelineRun list page--- > >https://drive.google.com/file/d/1HO6V5AnMSRqVgTTf1hAIT-COVCH2Q701/view?usp=drive_link > >------ > >----TaskRun list page--- > >https://drive.google.com/file/d/1FlOn6Zp3aEKxFlAmivy1IiFRWUUYrPyk/view?usp=drive_link > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-pipelines%2Fconsole-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-pipelines/console-plugin/blob/main/OWNERS)~~ [lokanandaprabhu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vikram-raj commented 4 weeks ago

/cherry-pick release-v1.16.x

openshift-cherrypick-robot commented 4 weeks ago

@vikram-raj: new pull request created: #166

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/161#issuecomment-2434744209): >/cherry-pick release-v1.16.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.