openshift-pipelines / console-plugin

OpenShift Pipelines (and Tekton) OpenShift console dynamic plugin
Apache License 2.0
2 stars 16 forks source link

Add dockerfile for console plugin #171

Closed savitaashture closed 2 weeks ago

savitaashture commented 3 weeks ago

Could we re-use the Dockerfile on the root of this git repo ?

Ya its almost same

but we add some labels and all

and also the component which is coming from hack repo alwasy points to .konflux folder so

savitaashture commented 2 weeks ago

/test images

savitaashture commented 2 weeks ago

/test images

vdemeester commented 2 weeks ago

The Dockerfile is also referenced by the prow build, and this is probably why ci/prow/images fails 😅

savitaashture commented 2 weeks ago

The Dockerfile is also referenced by the prow build, and this is probably why ci/prow/images fails 😅

:thinking: how to fix this

vdemeester commented 2 weeks ago

@savitaashture symbolic link or duplicate ?

savitaashture commented 2 weeks ago

@savitaashture symbolic link or duplicate ?

I mistakenly deleted original Dockerfile from root directory added back now lets see

vdemeester commented 2 weeks ago

@savitaashture that works 😉 /approve /lgtm

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-pipelines/console-plugin/blob/main/OWNERS)~~ [vdemeester] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment