openshift-pipelines / console-plugin

OpenShift Pipelines (and Tekton) OpenShift console dynamic plugin
Apache License 2.0
2 stars 16 forks source link

SRVKP-6463: Use Tasks from the `openshift-pipelines` namespace instead of ClusterTask #174

Closed lokanandaprabhu closed 2 weeks ago

lokanandaprabhu commented 2 weeks ago

Description: Since ClusterTask are deprecated from Pipelines 1.17, in Pipelines Builder page, instead of ClusterTask, task from openshift-pipelines namespace is used

Demo: https://drive.google.com/file/d/1FALHFqcXSD_rZm4I1_GyR_eoRG_hAM2G/view?usp=drive_link

openshift-ci-robot commented 2 weeks ago

@lokanandaprabhu: This pull request references SRVKP-6463 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/174): >**Description:** >Since ClusterTask are deprecated from Pipelines 1.17, in Pipelines Builder page, instead of ClusterTask, task from openshift-pipelines namespace is used > >**Demo:** >https://drive.google.com/file/d/1FALHFqcXSD_rZm4I1_GyR_eoRG_hAM2G/view?usp=drive_link Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-pipelines%2Fconsole-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sanketpathak commented 2 weeks ago

Verified the pr locally with admin and non-admin users (with proper rbac permission to openshift-pipelines namespace). I tried the following scenarios:

https://github.com/user-attachments/assets/faa5c6b4-59f0-449f-ad4f-1bd608d5ba22

Screenshot from 2024-11-08 15-10-18 Screenshot from 2024-11-08 16-14-07 Screenshot from 2024-11-08 16-15-23

/lgtm

openshift-ci[bot] commented 2 weeks ago

@sanketpathak: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/174#issuecomment-2464447447): >Verified the pr locally with admin and non-admin users (with proper rbac permission to openshift-pipelines namespace). I tried the following scenarios: > >- ClusterTask tab in admin view >- In Pipeline builder, tasks from openshift-pipelines namespace will appear, instead of ClusterTask and once you select and check in yaml view you should see resolver >- Add a task in a namespace with the same name as of a task from openshift-pipelines namespace and check in Pipeline builder for these two tasks and I yaml view with the difference of resolver in the task coming from openshift-pipelines namespace >- In pipeline details page selecting the task takes you to its parent namespace(where the task is created like openshift-pipelines namespace) >- Checked for ClusterTask references everywhere > >https://github.com/user-attachments/assets/faa5c6b4-59f0-449f-ad4f-1bd608d5ba22 > >![Screenshot from 2024-11-08 15-10-18](https://github.com/user-attachments/assets/22161df2-ce0f-47fd-80e7-1993f485a52d) >![Screenshot from 2024-11-08 16-14-07](https://github.com/user-attachments/assets/005079e8-7349-412f-8ef0-9a9df49527fc) >![Screenshot from 2024-11-08 16-15-23](https://github.com/user-attachments/assets/3b166c89-ddd7-436a-9b5a-366caa8c514d) > >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christoph-jerolimov, lokanandaprabhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-pipelines/console-plugin/blob/main/OWNERS)~~ [christoph-jerolimov,lokanandaprabhu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment