openshift-pipelines / console-plugin

OpenShift Pipelines (and Tekton) OpenShift console dynamic plugin
Apache License 2.0
2 stars 16 forks source link

Unable to remove finally tasks in pipeline builder mode #181

Open RoboMWM opened 2 days ago

RoboMWM commented 2 days ago

Expected Behavior

Finally task gets removed from pipeline when removing the finally tasks and saving the pipeline in the "pipeline builder" mode.

Actual Behavior

The finally tasks do not get removed and remain in the pipeline.

Steps to Reproduce the Problem

  1. Create a finally task in a pipeline in pipeline builder
  2. Save pipeline
  3. Edit pipeline and remove finally task in pipeline builder
  4. Save pipeline
  5. Observe that the finally task has not been removed

Additional Info

Lucifergene commented 2 days ago

/cc @lokanandaprabhu @vikram-raj

lokanandaprabhu commented 1 day ago

Thanks for reporting this. Created PR - https://github.com/openshift-pipelines/console-plugin/pull/183 to handle the issue.