search

openshift-pipelines / console-plugin

OpenShift Pipelines (and Tekton) OpenShift console dynamic plugin
Apache License 2.0
2 stars 16 forks source link

SRVKP-6739: Unable to remove finally tasks in pipeline builder mode #183

Closed lokanandaprabhu closed 1 week ago

lokanandaprabhu commented 2 weeks ago

Fixes: https://issues.redhat.com/browse/SRVKP-6739

Analysis / Root cause: If all Finally tasks are removed, existing Pipeline Finally task was considered, so user was not able to remove all the Finally tasks

Solution Description: Used finallyTasks from formData

Screen shots / Gifs for design review:

----BEFORE---

https://github.com/user-attachments/assets/2fb44ca2-1be6-44a9-9bad-b5337c151fed

---AFTER----

https://github.com/user-attachments/assets/07f9fda8-dfff-4942-be3a-b91dd1f474da

Unit test coverage report: NA

Test setup:

  1. Create a finally task in a pipeline in pipeline builder
  2. Save pipeline
  3. Edit pipeline and remove finally task in pipeline builder
  4. Save pipeline
  5. Observe that the finally task has not been removed

Browser conformance:

openshift-ci-robot commented 2 weeks ago

@lokanandaprabhu: This pull request references SRVKP-6739 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/183): >**Fixes**: >https://issues.redhat.com/browse/SRVKP-6739 > >**Analysis / Root cause**: >If all Finally tasks are removed, existing Pipeline Finally task was considered, so user was not able to remove all the Finally tasks > >**Solution Description**: >Used finallyTasks from formData > >**Screen shots / Gifs for design review**: > >----BEFORE--- > > >https://github.com/user-attachments/assets/2fb44ca2-1be6-44a9-9bad-b5337c151fed > > > > > > > > >---AFTER---- > > > > > >https://github.com/user-attachments/assets/07f9fda8-dfff-4942-be3a-b91dd1f474da > > > > > > > > > >**Unit test coverage report**: >NA > >**Test setup:** > >1. Create a finally task in a pipeline in pipeline builder >2. Save pipeline >3. Edit pipeline and remove finally task in pipeline builder >4. Save pipeline >5. Observe that the finally task has not been removed > > >**Browser conformance**: > >- [x] Chrome >- [ ] Firefox >- [ ] Safari >- [ ] Edge > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-pipelines%2Fconsole-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-pipelines/console-plugin/blob/main/OWNERS)~~ [lokanandaprabhu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lokanandaprabhu commented 2 weeks ago

/uncc @saumeya /cc @Lucifergene

lokanandaprabhu commented 1 week ago

/cherrypick release-1.16.x

openshift-cherrypick-robot commented 1 week ago

@lokanandaprabhu: cannot checkout release-1.16.x: error checking out "release-1.16.x": exit status 1 error: pathspec 'release-1.16.x' did not match any file(s) known to git

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/183#issuecomment-2477930963): >/cherrypick release-1.16.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
lokanandaprabhu commented 1 week ago

/cherry-pick release-v1.16.x

openshift-cherrypick-robot commented 1 week ago

@lokanandaprabhu: #183 failed to apply on top of branch "release-v1.16.x":

Applying: handled Unable to remove finally tasks in pipeline builder mode issue
Using index info to reconstruct a base tree...
A   src/components/pipeline-builder/utils.ts
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): src/components/pipeline-builder/utils.ts deleted in HEAD and modified in handled Unable to remove finally tasks in pipeline builder mode issue. Version handled Unable to remove finally tasks in pipeline builder mode issue of src/components/pipeline-builder/utils.ts left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 handled Unable to remove finally tasks in pipeline builder mode issue
In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/183#issuecomment-2477934951): >/cherry-pick release-v1.16.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
lokanandaprabhu commented 1 week ago

Pipeline builder was migrated in Pipelines release 1.17

So no need to migrate to 1.16.x branch