openshift-pipelines / console-plugin

OpenShift Pipelines (and Tekton) OpenShift console dynamic plugin
Apache License 2.0
2 stars 16 forks source link

SRVKP-6741: Remove duplicate root attribute in nginx.conf #185

Closed logonoff closed 4 hours ago

logonoff commented 2 weeks ago

Fixes https://issues.redhat.com/browse/SRVKP-6741

openshift-ci[bot] commented 2 weeks ago

Hi @logonoff. Thanks for your PR.

I'm waiting for a openshift-pipelines member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
logonoff commented 2 weeks ago

/cc @lokanandaprabhu

vikram-raj commented 6 hours ago

/ok-to-test

vikram-raj commented 4 hours ago

/jira refresh

openshift-ci-robot commented 4 hours ago

@vikram-raj: No Jira issue is referenced in the title of this pull request. To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/185#issuecomment-2493496090): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-pipelines%2Fconsole-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vikram-raj commented 4 hours ago

/retitle SRVKP-6741: Remove duplicate root attribute in nginx.conf

openshift-ci-robot commented 4 hours ago

@logonoff: This pull request references SRVKP-6741 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/185): >Fixes https://issues.redhat.com/browse/SRVKP-6741 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-pipelines%2Fconsole-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-pipelines/console-plugin/blob/main/OWNERS)~~ [vikram-raj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment