search

openshift-pipelines / manual-approval-gate

OpenShift Pipelines manual approval custom task
Apache License 2.0
1 stars 7 forks source link

Creates the dynamic client using `knative/pkg` #58

Closed PuneetPunamiya closed 10 months ago

PuneetPunamiya commented 10 months ago

Initially dynamic client was created using k8s.io/client-go, now with this patch it is created using knative/pkg

Signed-off-by: Puneet Punamiya ppunamiy@redhat.com

vdemeester commented 10 months ago

/approve

openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PuneetPunamiya, vdemeester

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-pipelines/manual-approval-gate/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment