openshift-pipelines / pipeline-service

SaaS for Tekton Pipelines
Apache License 2.0
23 stars 44 forks source link

Enable Tekton step-actions #1019

Closed enarha closed 2 months ago

enarha commented 2 months ago

This is already enabled and used in Konflux (see https://github.com/redhat-appstudio/infra-deployments/pull/3693 and https://github.com/redhat-appstudio/infra-deployments/pull/3818). Without having the configuration in pipeline-service, updates were overriding the values. This will not generate diff in Konflux.

enarha commented 2 months ago

did not realize the delete was occuring on the merge

more motivation perhaps @enarha to move forward with something like redhat-appstudio/infra-deployments@main...gabemontero:infra-deployments:copy-over-plnsrvce-2 and run kustomize build ... on the two spots in this repo in components/pipelines and then add the grafana panels and be done with his, no?

Generally speaking, yeah, I agree we should move away from pipeline-service. Few drawbacks I can think of are:

but these are small issues.

enarha commented 2 months ago

/test test-pipeline-service-upgrade-ocp-414

enarha commented 2 months ago

/test test-pipeline-service-deployment-ocp-414

enarha commented 2 months ago

/test test-pipeline-service-upgrade-ocp-414

enarha commented 2 months ago

/test test-pipeline-service-deployment-ocp-414

gabemontero commented 2 months ago

FYI for those besides @enarha and myself, these technically intermittent but pretty persistent issues accessing the provisioned ROSA clusters is getting worked in https://redhat-internal.slack.com/archives/C032EJ007C0/p1720725499450859 .... currently trying to sort out with the infra team why @xinredhat cannot access the konflux-ci namespace

gabemontero commented 2 months ago

given this setting was working before @enarha feel free to merge without the CI passing ... I'll refrain from doing it myself in case there was something you wanted to confirm

enarha commented 2 months ago

tested manually, tests passed.