[DO-NOT-MERGE-YET] turn on pprof in core controller to allow for goroutine dumps

openshift-pipelines / pipeline-service

SaaS for Tekton Pipelines

Apache License 2.0

23 stars 44 forks source link

[DO-NOT-MERGE-YET] turn on pprof in core controller to allow for goroutine dumps #1024

Open gabemontero opened 2 months ago

gabemontero commented 2 months ago

per the golang recommendations that pprof enablement is OK in production, we are enabling to allow for gathering goroutine dumps as part of diagnosing deadlocks.

rh-pre-commit.version: 2.3.0 rh-pre-commit.check-secrets: ENABLED

enarha commented 2 months ago

lgtm. Feel free to merge.

gabemontero commented 2 months ago

lgtm. Feel free to merge.

thanks @enarha

unfortunately with local testing I cannot get goroutine dumps from the pipeline controller like I can with the results watcher, even though AFAIU I'm configuring the same way via the config-observability config map.

been debugging a bit, will a bit more, but may reach out on #team-ocp-pipelines for some help.