search

openshift-pipelines / pipeline-service

SaaS for Tekton Pipelines
Apache License 2.0
23 stars 44 forks source link

[DNM] Delete PipelineRuns immediately after completion #905

Closed Roming22 closed 5 months ago

Roming22 commented 8 months ago

rh-pre-commit.version: 2.0.3 rh-pre-commit.check-secrets: ENABLED

gabemontero commented 8 months ago

Per discussion in slack, some of the upstream metrics, and all of the pipeline service exporter metrics, are accumulated after a pipelinerun is completed.

Odd timing issues, race conditions, could arise as if the deletes happen this fast.

Testing / more investigation is most likely needed. Possibly some sort of lessening of the time out, but not going immediately, might be needed.

ramessesii2 commented 7 months ago

We've a duplicate PR #868. I'll close that in favor of this one. However, as this comment on #868 mentions that we get into race conditions with immediate pruning, and there is a downstream JIRA issue dedicated to fixing it which is most likely needed to get this PR merged.

Roming22 commented 7 months ago

Do not merge this PR until the issue with logs not being synced before the resource is deleted is solved.

gabemontero commented 7 months ago

Do not merge this PR until the issue with logs not being synced before the resource is deleted is solved.

Add to ^^: until we do sufficient testing/verification that knative/controller-runtime won't aggregate events such that our various metrics, both upstream and the exporter, that are calculated after the pipelinerun is complete are not negatively impacted

Roming22 commented 5 months ago

@gabemontero @enarha I'll let you decide what you want to do with this PR. You may decide you do not want to delete PLR as soon as they complete.

gabemontero commented 5 months ago

@gabemontero @enarha I'll let you decide what you want to do with this PR. You may decide you do not want to delete PLR as soon as they complete.

yeah we are a ways from being able to do this IMO