search

openshift-pipelines / pipeline-service

SaaS for Tekton Pipelines
Apache License 2.0
23 stars 44 forks source link

PLNSRVCE-1585: exporter needs patch permissions #919

Closed gabemontero closed 7 months ago

gabemontero commented 7 months ago

Part of the exporter's new approach to filter throttled pipelineruns because of the pipeline controller's aggressiver requeue strategy with throttling is that it labels the pipelinerun for later filtering. However, the original introduction of the changes did not add patch permissions to the exporter's RBAC. This change addresses that.

rh-pre-commit.version: 2.1.0 rh-pre-commit.check-secrets: ENABLED

Roming22 commented 7 months ago

/lgtm

@xinredhat Can you check if there's a reason why the upgrade test is flaking?

gabemontero commented 7 months ago

/lgtm

@xinredhat Can you check if there's a reason why the upgrade test is flaking?

the upgrade test flaked in https://github.com/openshift-pipelines/pipeline-service/pull/920 as well

gabemontero commented 7 months ago

I'm merging this @Roming22 since an RBAC addition will not affect an upgrade