I'll create a test PR in infra-deployments that uses this branch and if it confirms my previous findings that the results watcher was OK until this commit, we'll then merge this revert to unblock the pipeline-service flow into infra-deployments, and @Roming22 and whoever else can help him will sort out how this commit needs to be changed to work properly in infra-deployments.
gabemontero
commented
6 months ago
This reverts commit a2fce5ab5b0536f1ea4853a3283587e9a726ee97.
per discussion in https://redhat-internal.slack.com/archives/C032EJ007C0/p1708442957771559 it looks like PR https://github.com/openshift-pipelines/pipeline-service/pull/935 had the odd effect of deleting the results watcher deployment in the infra-deployment's developer overlay (minimally)
I'll create a test PR in infra-deployments that uses this branch and if it confirms my previous findings that the results watcher was OK until this commit, we'll then merge this revert to unblock the pipeline-service flow into infra-deployments, and @Roming22 and whoever else can help him will sort out how this commit needs to be changed to work properly in infra-deployments.
@openshift-pipelines/pipelines-service FYI