search

openshift-pipelines / pipeline-service

SaaS for Tekton Pipelines
Apache License 2.0
23 stars 44 forks source link

Removed enabling HTTP2 #967

Closed xinredhat closed 6 months ago

xinredhat commented 6 months ago

rh-pre-commit.version: 2.1.0 rh-pre-commit.check-secrets: ENABLED

gabemontero commented 6 months ago

the upgrade failed cause main branch has the http2 issue:

[cluster-setup]
- Enabling HTTP2 for ingress:
+ '[' yes '!=' yes ']'
+ cluster_setup
+ echo '[cluster-setup]'
+ echo '- Enabling HTTP2 for ingress:'
+ oc annotate ingresses.config/cluster ingress.operator.openshift.io/default-enable-http2=true --overwrite=true
+ indent 2
+ offset=2
++ printf %2s
+ sed 's/^/  /'
Error from server (Only privileged service accounts may access): admission webhook "ingress-config-validation.managed.openshift.io" denied the request: Only privileged service accounts may access
command terminated with exit code 1
Failed to execute dev_setup.sh script, retrying ...
+ echo 'Failed to execute dev_setup.sh script, retrying ...'
+ sleep 5

With the pr branch test passing, this is good to go @Roming22 @xinredhat

I am merging.