search

openshift-pipelines / pipeline-service

SaaS for Tekton Pipelines
Apache License 2.0
23 stars 44 forks source link

Use the TektonConfig to customize the logging #972

Closed enarha closed 6 months ago

enarha commented 6 months ago

We have been using kustomize to create ConfigMap (config-logging) to customize the pipelines' pods logs to adhere with ADR-6. That configuration is now overriden by the Tekton operator. We use the TektonConfig now to customize the logs. Added configuration for triggers log.

gabemontero commented 6 months ago

Looked at the logs for the failed upgrade test, and the storage pod had a failure / restart during the downgrade test:

[test-downgrade : run-tests] {"level":"info","ts":"2024-03-17T19:56:07.412Z","logger":"watcher","caller":"pipelinerun/reconciler.go:74","msg":"Initiating reconciliation for PipelineRun 'plnsvc-tests/test-pipelinerun-65mn4'","knative.dev/traceid":"aa03f9da-10f5-4bdb-9db5-1562f928d867","knative.dev/key":"plnsvc-tests/test-pipelinerun-65mn4","results.tekton.dev/kind":"PipelineRun"}
[test-downgrade : run-tests] {"level":"warn","ts":"2024-03-17T19:56:07.530Z","logger":"watcher","caller":"dynamic/dynamic.go:510","msg":"flush ret count","knative.dev/traceid":"6a765770-42e2-4a75-8170-1e6e37d5269b","knative.dev/key":"plnsvc-tests/test-pipelinerun-65mn4","results.tekton.dev/kind":"PipelineRun","name":"test-pipelinerun-65mn4","flushCount":1453}
[test-downgrade : run-tests] + oc get pods -n tekton-results
[test-downgrade : run-tests] NAME                                     READY   STATUS    RESTARTS      AGE
[test-downgrade : run-tests] postgres-postgresql-0                    1/1     Running   0             8m27s
[test-downgrade : run-tests] storage-pool-0-0                         2/2     Running   2 (71s ago)   7m10s
[test-downgrade : run-tests] tekton-results-api-677c48849c-kxm87      2/2     Running   0             8m27s
[test-downgrade : run-tests] tekton-results-watcher-8655df6b8-6j9xz   2/2     Running   0             4m24s
[test-downgrade : run-tests] + exit 1
[test-downgrade : run-tests] command terminated with exit code 1
[test-downgrade : run-tests] + exit 1

pretty usre this is the intermittent test flake with the upgrade/downgrade that we've been chasing.

@enarha feel free to merge this once you've confirmed my configMap options question

ramessesii2 commented 6 months ago

/test test-pipeline-service-upgrade-ocp-414

gabemontero commented 6 months ago

Per my comment https://github.com/openshift-pipelines/pipeline-service/pull/972#issuecomment-2002649468 the upgrade failure is an unrelated flake

Merging