search

openshift-pipelines / pipeline-service

SaaS for Tekton Pipelines
Apache License 2.0
20 stars 43 forks source link

Add konflux-ci namespace to cleaning secrets script #981

Closed enarha closed 3 months ago

enarha commented 3 months ago

https://github.com/redhat-appstudio/infra-deployments/pull/3481 introduced change to the pipeline-service deploy.yaml files we generate automatically overriding those changes. Here we move the change to the pipeline-service repo.

enarha commented 3 months ago

@ralphbean

gabemontero commented 3 months ago

makes sense @enarha, though since @ralphbean changed our cronjob on us in prod arleady, do you have any idea if this means that UNTIL

disable their repository entry in the tekton-ci namespace and enable their repository in the konflux-ci namespace by editing the repository entries for each here in infra-deployments.

whatever this cron job is suppose to be doing for our pac secret is effectively broken?

Or do we need to reach out to Romain to answer that question?

enarha commented 3 months ago

@gabemontero I really do not know to answer your question, but without this change each time we generate the deploy.yaml files (for both stage and prod) we override this values. Furthermore the changes we generate include that override which is confusing when you review the infra-deployments changes. I would rather merge that PR soon. It does not have any effect on infra-deployments other than preserving the configuration already there.

enarha commented 3 months ago

After offline sync we decided to go ahead and merge.