search

openshift-pipelines / pipelines-as-code

Pipelines-as-Code for Tekton
https://pipelinesascode.com
Apache License 2.0
130 stars 80 forks source link

GitHub checks details link to cats #1021

Open lbernick opened 1 year ago

lbernick commented 1 year ago
Screenshot 2022-11-23 at 3 41 43 PM

When clicking on the links in this picture, it redirects to https://giphy.com/search/random-cats 🐱 I'm using the IP address of an ingress I set up on GKE, so this might be what happens when PAC cannot resolve a route url.

chmouel commented 1 year ago

You need to configure it and set the url of the dashboard as documented here: https://pipelinesascode.com/docs/install/kubernetes/#tekton-dashboard-integration

(i'd love to be able to auto discover this but I am not sure if there is any standardize way to be able to do this)

lbernick commented 1 year ago

Would it be possible to instead display some message explaining that the dashboard needs to be set up?

chmouel commented 1 year ago

yes that would be perhaps better, there is some call in Github checks API expecting a real URL (which we could set to tekton.cd or something) but for the task breakdown we can just avoid showing a link and show a message otherwise....