openshift-pipelines / pipelines-as-code

Pipelines-as-Code for Tekton

https://pipelinesascode.com

Apache License 2.0

129 stars 81 forks source link

Fork in github pull request skipped - User X is not allowed to run CI on this repo #1253

Open skv-patrik opened 1 year ago

skv-patrik commented 1 year ago

Behaviour:

User X has no write permission in github repo Y in organization A
User X is a public member of organization A
User X must create a fork Y in user X repo
When user X creates a pull request, pipelines as code is skipping the commit: User X is not allowed to run CI on this repo.

Wanted behaviour:

Pipeline as code shall not skip commit if user belongs to organization A

Workaround:

A user with permission in github repo Y in organization A comment /ok-to-test

Components:

Red Hat Openshift Pipeline: 1.10.2
Tekton Pipelines: v0.44.2
Tekton Triggers: v0.23.1
Pipelines as Code: 0.17.2

chmouel commented 1 year ago

do you have by any chances a large github organisation? because we fixed this in 0.17.2 https://github.com/openshift-pipelines/pipelines-as-code/releases/tag/v0.17.2

the behavior you described should be allowed..

if you are openshift customer maybe send a bug report via red hat access portal this would help prioritizing this for a backport to 1.9.x

skv-patrik commented 1 year ago

Thank you @chmouel Yes, we have a large github (enterprise) organisation. And we are an openshift customer so I will contact them.

chmouel commented 1 year ago

@skv-patrik it is shipped in 1.10 which has been released last week so if you have the chance to upgrade to this version you will be able to get the fix there too! but backport should be fine too..

skv-patrik commented 1 year ago

@chmouel - this error remains after the update. (I updated the versions above to the latest). Open this issue again? Or shall I create a new one?

chmouel commented 1 year ago

This is weird is the user not a collaborator on Repo implicitely if they re in org?

i am not so sure how to reproduce but i am going to add pagination support everywhere on those calls

chmouel commented 1 year ago

1379 should add pagination and fix this

is there any chance you can create a access.redhat.com ticket about this so we can track that work to prioritize for backport?

skv-patrik commented 1 year ago

This is weird is the user not a collaborator on Repo implicitely if they re in org?

No, they are not collaborator implicitely .

It looks like this rule doesn't work: The author of the pull request is a public or private member of the organization that owns the repository.

chmouel commented 1 year ago

ok i think the paging fix should work then...