codecov[bot]
commented
6 months ago Codecov Report
Attention: Patch coverage is 41.66667% with 7 lines in your changes are missing coverage. Please review.
Project coverage is 64.04%. Comparing base (
8bfeac7) to head (8e5b6f1). Report is 5 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| pkg/sort/runtime_sort.go | 0.00% | 4 Missing :warning: |
| pkg/pipelineascode/concurrency.go | 62.50% | 2 Missing and 1 partial :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1636 +/- ## ========================================== - Coverage 64.19% 64.04% -0.16% ========================================== Files 140 140 Lines 10878 10888 +10 ========================================== - Hits 6983 6973 -10 - Misses 3363 3382 +19 - Partials 532 533 +1 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
chmouel
Changes
we use sort code from k8s repo, this updates the code to the latest master https://github.com/kubernetes/kubernetes/blob/20d0ab7ae808aaddb1556c3c38ca0607663c50ac/staging/src/k8s.io/kubectl/pkg/cmd/get/sorter.go#L150 but keeps using integer.IntMin to continue using golang 1.20
Submitter Checklist
[ ] 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
[ ] ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
[ ] ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
[ ] 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
[ ] 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
[ ] 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
[ ] 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).