codecov[bot]
commented
6 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 64.13%. Comparing base (
f10ee61) to head (1d4347f). Report is 3 commits behind head on main.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1639 +/- ## ========================================== + Coverage 64.11% 64.13% +0.02% ========================================== Files 140 141 +1 Lines 10871 10878 +7 ========================================== + Hits 6970 6977 +7 Misses 3385 3385 Partials 516 516 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
piyush-garg
When we have multiple matches for the same repository, we need to make sure we only get the oldest one. This is important since we pac assumes the first one is the one that should be used, to avoid an hijacking scenario.
This should never happen in practice since we have our webhook that make sure we only have one repository per URL per cluster. If for whichever reasons the webhook is crashing or the admin has disabled it then at least we are covered
Changes
Submitter Checklist
[ ] 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
[ ] ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
[ ] ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
[ ] 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
[ ] 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
[ ] 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
[ ] 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).