openshift-pipelines / pipelines-as-code

Pipelines-as-Code for Tekton
https://pipelinesascode.com
Apache License 2.0
130 stars 80 forks source link

fix TestGithubPushRequestGitOpsCommentCancel #1641

Closed chmouel closed 6 months ago

chmouel commented 6 months ago

when the pipelinerun goes to quick to finish it would not be able to check if it's canceled, to avoid that flakyness we say it's okay when we have found it in the controller log that the request has been sent over. There is other test testing cancellation anyway

Signed-off-by: Chmouel Boudjnah chmouel@redhat.com

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.09%. Comparing base (e553256) to head (02aa551). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1641 +/- ## ======================================= Coverage 64.09% 64.09% ======================================= Files 140 140 Lines 10897 10897 ======================================= Hits 6984 6984 Misses 3380 3380 Partials 533 533 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.