codecov[bot]
commented
3 months ago Codecov Report
Attention: Patch coverage is 82.35294% with 6 lines in your changes are missing coverage. Please review.
Project coverage is 64.11%. Comparing base (
c703cd8) to head (b4b06cf).
| Files | Patch % | Lines |
|---|---|---|
| pkg/provider/github/app/token.go | 80.00% | 4 Missing and 2 partials :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1642 +/- ## ========================================== + Coverage 64.09% 64.11% +0.02% ========================================== Files 140 140 Lines 10897 10912 +15 ========================================== + Hits 6984 6996 +12 - Misses 3380 3382 +2 - Partials 533 534 +1 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
we were calling:
each time on each isntallationData when this call can only be done once and be cached.
using a struct and refactor the code to use it.
Changes
Submitter Checklist
[ ] 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
[ ] ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
[ ] ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
[ ] 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
[ ] 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
[ ] 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
[ ] 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).