codecov[bot]
commented
3 months ago Codecov Report
Attention: Patch coverage is 93.97590% with 10 lines in your changes are missing coverage. Please review.
Project coverage is 64.62%. Comparing base (
3274759) to head (9d45d01).:exclamation: Current head 9d45d01 differs from pull request most recent head 78fd105. Consider uploading reports for the commit 78fd105 to get more accurate results
| Files | Patch % | Lines |
|---|---|---|
| pkg/configutil/config.go | 85.07% | 8 Missing and 2 partials :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1643 +/- ## ========================================== + Coverage 64.11% 64.62% +0.50% ========================================== Files 140 141 +1 Lines 10912 10961 +49 ========================================== + Hits 6996 7083 +87 + Misses 3382 3355 -27 + Partials 534 523 -11 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
chmouel
enarha
sm43
adds a package to replace code in settings for validation and defaults with a generic func, using json tag for defaulting. and for figuring out which field it is from configmap.
Changes
Submitter Checklist
[x] 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
[x] ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
[x] ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
[x] 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
[x] 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
[x] 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
[x] 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).